Add support for 1x2 layout by timcogan · Pull Request #18 · timcogan/perspecta

timcogan · 2026-02-25T21:51:45Z

Summary by CodeRabbit

New Features
- Expanded multi-view support to flexible layouts: 1x1, 1x2, and 2x2 configurations
- Dynamic UI grid rendering that adapts to actual image counts
- Improved streaming and loading behavior for multi-view groups
Bug Fixes
- More accurate active-group detection and completion handling for 2- and 4-image groups
- Clearer multi-view status and error messages
Tests
- Updated test coverage to validate 1-, 2- and 4-image multi-view scenarios

coderabbitai · 2026-02-25T21:52:02Z

Warning

Rate limit exceeded

@timcogan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 901578e and aa2f073.

📒 Files selected for processing (3)

README.md
src/app.rs
src/dicomweb.rs

📝 Walkthrough

Walkthrough

Generalizes mammography group handling from fixed 4-image sets to support 1-, 2-, or 4-image multi-view groups. Adds helpers for validating group sizes, computing grid dimensions and labels; updates DICOMWeb grouping/validation, UI grid rendering, streaming logic, status messages, history/preload paths, and tests.

Changes

Cohort / File(s)	Summary
App multi-view logic `src/app.rs`	Adds `is_supported_multi_view_group_size()`, `multi_view_grid_dimensions()`, `multi_view_layout_label()` and replaces hard-coded 2x2/4-image assumptions with dynamic 1/2/4 handling across group checks, UI grid rendering, status messages, history/preload, and tests.
DICOMWeb group validation `src/dicomweb.rs`	Expands validation to accept 1, 2, or 4 series UIDs/instances per group; adds early return path for 2-instance resolved sets in `reduce_series_instances()` and updates error messages to reflect allowed counts.
Tests & messaging `tests/...`, `src/...` status strings	Updates test expectations and user-facing status/error messages to reference 1x1, 1x2, and 2x2 multi-view terminology instead of fixed 2x2 wording.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant UI as UI / Renderer
participant App as DicomViewerApp
participant DWeb as DICOMWeb Client
UI->>App: request/load multi-view group (1/2/4)
App->>DWeb: query series/group instances
DWeb-->>App: return 1/2/4 instances
App->>App: validate with is_supported_multi_view_group_size()
alt valid group
App->>UI: compute grid (multi_view_grid_dimensions), render slots
UI-->>App: request instance streaming per slot
App->>DWeb: stream instances
DWeb-->>App: stream chunks / complete
App->>UI: update slot(s) / status messages
else invalid group
App->>UI: show error message (allowed: 1,2,4)
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Unify mammo ordering and move mammo helpers #4 — Modifies mammo grid/thumbnail composition and slot allocation; overlaps with multi-view grid sizing and slot logic changes.
Improve image loading speed #15 — Restructures group load/streaming paths and pending load handling; touches the same group-loading and streaming flows adjusted here.

Poem

🐰 From four we now hop to one or two,
Small grids that fit the views we choose anew.
Helpers count and label, rows and columns play,
A rabbit cheers: flexible mammo day! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.17% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding support for 1x2 layout alongside existing 2x2 support by generalizing multi-view group handling to support 2- or 4-image configurations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/1x2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/app.rs`:
- Around line 261-264: The clippy "redundant closure" warning comes from using
closures like |count| Self::is_supported_multi_view_group_size(count) when
checking dicomweb_active_group_expected; replace those closures with a direct
function pointer reference (Self::is_supported_multi_view_group_size) in all
three occurrences (the call sites around dicomweb_active_group_expected /
dicomweb_active_path_receiver and the other two locations referenced) so the
Option::is_some_and uses the function reference instead of the unnecessary
closure.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7953d7b and f507a18.

📒 Files selected for processing (2)

src/app.rs
src/dicomweb.rs

src/app.rs

coderabbitai bot reviewed Feb 25, 2026

View reviewed changes

src/app.rs Show resolved Hide resolved

timcogan force-pushed the feat/1x2 branch from f507a18 to 901578e Compare February 25, 2026 22:01

Add support for 1x2 layout

aa2f073

timcogan force-pushed the feat/1x2 branch from 901578e to aa2f073 Compare February 25, 2026 22:05

timcogan merged commit 12460e4 into master Feb 26, 2026
7 checks passed

timcogan deleted the feat/1x2 branch February 26, 2026 12:12

coderabbitai bot mentioned this pull request Feb 26, 2026

fix(launch): allow 1x2 groups in perspecta URI parser #19

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for 1x2 layout#18

Add support for 1x2 layout#18
timcogan merged 1 commit intomasterfrom
feat/1x2

timcogan commented Feb 25, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

timcogan commented Feb 25, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

timcogan commented Feb 25, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2026 •

edited

Loading